Fix using bad base block #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #51 by introducing the
Rebase.BaseBlocksInRange(begin, end Hash) intin combination with addingBlockchain.LatestBaseBlock. One notable difference from #51 is that we do not do explicit block resynchronisation.The network assumptions of Tendermint (and therefore Hyperdrive), is that all messages are eventually delivered. This means that we do not need to explicitly resync, because all
Proposeswill eventually be seen and base blocks will be accepted as part of this. This is a less efficient approach then explicit resynchronisation, so an issue for this has been created and will be implemented in the next release (see #77). It is not implemented for now, because we will be doing an overall review of all data synchronisation to reduce memory allocations and network bandwidth.